This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Numpy] operator arctan2 #15890
Merged
reminisce
merged 1 commit into
apache:numpy_staging_prs
from
tingying2020:ms_arctan2_new
Sep 23, 2019
Merged
[Numpy] operator arctan2 #15890
reminisce
merged 1 commit into
apache:numpy_staging_prs
from
tingying2020:ms_arctan2_new
Sep 23, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haojin2
reviewed
Aug 15, 2019
def hybrid_forward(self, F, x1, x2): | ||
return F.np.arctan2(x1, x2) | ||
|
||
#Reduce dimension of src to dimention of des. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Reduce dimension of src to dimension of des.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
tingying2020
force-pushed
the
ms_arctan2_new
branch
from
August 20, 2019 07:13
f4fcb50
to
9001860
Compare
tingying2020
force-pushed
the
ms_arctan2_new
branch
6 times, most recently
from
September 16, 2019 07:34
77fdfb2
to
effd142
Compare
haojin2
approved these changes
Sep 16, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@tingying2020 could you resolve conflicts? |
tingying2020
force-pushed
the
ms_arctan2_new
branch
from
September 17, 2019 10:29
effd142
to
fc6ec51
Compare
* change the test code * add @use_np in test code * only support float16, float32 and float64. * fix format error * remove redundant backslash * change wrapper in symbol * delete gpu test * edit test * change infer type * remove redundant **kwargs * change atol and rtol in test * edit test shape
reminisce
force-pushed
the
ms_arctan2_new
branch
from
September 23, 2019 05:37
fc6ec51
to
3e008ed
Compare
5 tasks
reminisce
pushed a commit
that referenced
this pull request
Sep 23, 2019
* change the test code * add @use_np in test code * only support float16, float32 and float64. * fix format error * remove redundant backslash * change wrapper in symbol * delete gpu test * edit test * change infer type * remove redundant **kwargs * change atol and rtol in test * edit test shape
drivanov
pushed a commit
to drivanov/incubator-mxnet
that referenced
this pull request
Sep 26, 2019
* change the test code * add @use_np in test code * only support float16, float32 and float64. * fix format error * remove redundant backslash * change wrapper in symbol * delete gpu test * edit test * change infer type * remove redundant **kwargs * change atol and rtol in test * edit test shape
larroy
pushed a commit
to larroy/mxnet
that referenced
this pull request
Sep 28, 2019
* change the test code * add @use_np in test code * only support float16, float32 and float64. * fix format error * remove redundant backslash * change wrapper in symbol * delete gpu test * edit test * change infer type * remove redundant **kwargs * change atol and rtol in test * edit test shape
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pr after rebase.